Skip to content

Use String.trim_trailing/1 over the deprecated String.rstrip/1 #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2017
Merged

Use String.trim_trailing/1 over the deprecated String.rstrip/1 #726

merged 1 commit into from
May 20, 2017

Conversation

whatyouhide
Copy link
Member

ExDoc already depends on Elixir ~> 1.3 where String.trim_trailing/1 was introduced, so there's no backwards compatibility issue.

@whatyouhide
Use String.trim_trailing/1 over the deprecated String.rstrip/1
7354495 
ExDoc already depends on Elixir ~> 1.3 where String.trim_trailing/1 was
introduced, so there's no backwards compatibility issue.
@milmazz
Copy link
Member

milmazz commented May 20, 2017

@whatyouhide Thanks! <3

@milmazz milmazz merged commit 4786480 into elixir-lang:master May 20, 2017
@whatyouhide whatyouhide deleted the rstrip-deprecated branch May 20, 2017 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whatyouhide @milmazz